Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/modal): ensure that key down listener gets called #870

Merged
merged 6 commits into from
Nov 13, 2023
Merged

fix(core/modal): ensure that key down listener gets called #870

merged 6 commits into from
Nov 13, 2023

Conversation

nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Oct 23, 2023 •
edited by danielleroux
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: Closes #848

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@nuke-ellington nuke-ellington added this to the 2.1.0 milestone Oct 23, 2023
danielleroux
danielleroux requested changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component test is missing

@danielleroux danielleroux modified the milestones: 2.1.0, 2.0.4 Nov 6, 2023
@nuke-ellington nuke-ellington modified the milestones: 2.0.4, 2.1.0 Nov 8, 2023
@nuke-ellington nuke-ellington merged commit ceacb71 into main Nov 13, 2023
nuke-ellington added a commit that referenced this pull request Nov 20, 2023
@nuke-ellington
fix(core/modal): ensure that key down listener gets called (#870)
2b86a2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Modal: not possible to disable close function by clicking on ESC
2 participants
@nuke-ellington @danielleroux